RE: Recent test results

["Keshavamurthy, Anil S" <anil dot s dot keshavamurthy at intel dot com>]

Bibo,
	Adding printf() in librelay.c file is wrong thing. For example when a scrip is run say
"./my_test.stp" and then a CTRL+C, users will see your printf("systemtap unload module successful")
which is a wrong thing as user is not expected to see any thing other than what is described in their script.

Rejecting your patch.

-Anil Keshavamurthy
>-----Original Message-----
>From: Mao, Bibo 
>Sent: Sunday, November 13, 2005 7:42 PM
>To: 'Martin Hunt'; Keshavamurthy, Anil S
>Cc: William Cohen; systemtap@sources.redhat.com
>Subject: RE: Recent test results
>
>Yes, after add close and wait sentence in stap_run.exp. There 
>will be no timeout information. But after "runtest" command, 
>if we use lsmod command, there will be some module that is not 
>uninstalled named stapxxx.
>
>Maybe it is because of spawn process is closed before it 
>unload stap module. We can print some information when rmmod 
>in file librelay.c. And then expect this information in 
>stap_run.exp script, and at last after unload module, we can 
>close this process.
>
>By the way stap_fun.exp function is only called by runtest 
>script in systemtap.base directory, and in systemtap.samples 
>directory it is not. Maybe we add wait sentence in each 
>runtest exp script in systemtap.samples directory.
>
>The attachment is patch for librelay.c and stap_run.exp.
>
>>-----Original Message-----
>>From: systemtap-owner@sourceware.org 
>[mailto:systemtap-owner@sourceware.org]
>>On Behalf Of Martin Hunt
>>Sent: 2005年11月12日 4:53
>>To: Keshavamurthy, Anil S
>>Cc: William Cohen; systemtap@sources.redhat.com
>>Subject: RE: Recent test results
>>
>>On Fri, 2005-11-11 at 12:49 -0800, Keshavamurthy, Anil S wrote:
>>> Martin,
>>> 	Can you mail your fix so I can verify the same on my Ia64 box.
>>>
>>> -thanks,
>>> Anil
>>
>>Index: testsuite/lib/stap_run.exp
>>===================================================================
>>RCS file: /cvs/systemtap/tests/testsuite/lib/stap_run.exp,v
>>retrieving revision 1.5
>>retrieving revision 1.6
>>diff -u -r1.5 -r1.6
>>--- testsuite/lib/stap_run.exp  2 Sep 2005 22:34:12 -0000       1.5
>>+++ testsuite/lib/stap_run.exp  11 Nov 2005 20:37:47 -0000      1.6
>>@@ -51,6 +51,8 @@
>>        timeout { fail "$test startup (timeout)" }
>>        eof { fail "$test startup (eof)" }
>>     }
>>+  close
>>+  wait
>> }
>>
>> proc no_load {} {
>>
>>--------
>>
>>It's checked into CVS.
>>
>>Martin
>>
>
>