This is the mail archive of the systemtap-cvs@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.9.9-197-g8096dd7


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "systemtap: system-wide probe/trace tool".

The branch, master has been updated
       via  8096dd7dbc7bc5712da58a6f9bcb90c0b74c10db (commit)
       via  546499713651809f026e118f81b9c52f01c895f6 (commit)
       via  8a9a609f15c3088bcaaf9728393662372f91ab62 (commit)
       via  b13d5a188321fc6856cf379a74b3004ce094a3af (commit)
      from  fdef9f1f12e4a087c87c8bf7e5078f88fcc0d33f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8096dd7dbc7bc5712da58a6f9bcb90c0b74c10db
Author: Josh Stone <jistone@redhat.com>
Date:   Wed Aug 26 20:09:48 2009 -0700

    Reorganize iterate_over_labels
    
    I noticed that iterate_over_labels was using a static variable as a
    recursion variable, which isn't a safe thing to do since it will only be
    initialized once.  While fixing that, I also reorganized the function
    quite a bit.
    
    * dwflpp.cxx (dwflpp::iterate_over_labels): Take the current function as
      a parameter instead of using a static local.  Rewrite some of the code
      as well to try to make it more obvious.
    * tapsets.cxx (add_label_name): Remove in favor of query_label.
      (query_label): New, to check decl_file and fix probe listing.
      (query_srcfile_label, query_cu): Adjust to iterate_over_labels change
      and start using query_label as the callback.

commit 546499713651809f026e118f81b9c52f01c895f6
Author: Josh Stone <jistone@redhat.com>
Date:   Wed Aug 26 17:35:54 2009 -0700

    Remove unnecessary static members
    
    When a static class member is only used by a single method, it's more
    concise to use a static local variable instead.
    
    * staptree.cxx (probe::probe): Make last_probeidx a static local.
    * tapset-perfmon.cxx (perfmon_derived_probe::perfmon_derived_probe):
      Make probes_allocated a static local.

commit 8a9a609f15c3088bcaaf9728393662372f91ab62
Author: Josh Stone <jistone@redhat.com>
Date:   Wed Aug 26 17:05:29 2009 -0700

    Cleanup some deref handling in the task tapset
    
    Some of this is just cosmetic, but there is one big takeaway: there's a
    error-goto between kread calls and the CATCH_DEREF_FAULT.  You must not
    allow this to bypass any resource management, like unlocking a resource
    that you grabbed!
    
    * tapset/task.stp (pid2task): No derefs, so remove the CATCH.
      (task_gid, task_egid, task_uid, task_euid): Move the CATCH within the
      #ifdef branch that actually needs it.
      (task_open_file_handles, task_max_file_handles): Ensure that we always
      call rcu_read_unlock if we locked it!

commit b13d5a188321fc6856cf379a74b3004ce094a3af
Author: Josh Stone <jistone@redhat.com>
Date:   Wed Aug 26 16:15:46 2009 -0700

    Correct a few comments to match the code
    
    * tapset/conversions.stp (kernel_long, kernel_int, kernel_short,
      kernel_char): All are actually using kread(), not deref().
    * tapset/i386/registers.stp (_stp_arg): Ditto.
    * tapset/x86_64/registers.stp (_stp_arg): Ditto.

-----------------------------------------------------------------------

Summary of changes:
 dwflpp.cxx                  |   93 +++++++++++++++++++-----------------------
 dwflpp.h                    |   11 +++--
 staptree.cxx                |    2 +-
 staptree.h                  |    3 -
 tapset-perfmon.cxx          |   10 +----
 tapset/conversions.stp      |    8 ++--
 tapset/i386/registers.stp   |    2 +-
 tapset/task.stp             |   31 +++++++++-----
 tapset/x86_64/registers.stp |    2 +-
 tapsets.cxx                 |   47 +++++++++++++++-------
 10 files changed, 109 insertions(+), 100 deletions(-)


hooks/post-receive
--
systemtap: system-wide probe/trace tool


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]