This is the mail archive of the
sid@sources.redhat.com
mailing list for the SID project.
Re: [RFA]: hw-glue-bus-mux selection behavior
- To: Dave Brolley <brolley at redhat dot com>
- Subject: Re: [RFA]: hw-glue-bus-mux selection behavior
- From: "Frank Ch. Eigler" <fche at redhat dot com>
- Date: Tue, 27 Mar 2001 19:04:54 -0500
- Cc: sid at sources dot redhat dot com
- References: <3AC124C3.7060604@redhat.com>
Hi -
On Tue, Mar 27, 2001 at 06:39:47PM -0500, Dave Brolley wrote:
: [...]
: Notes:
: 1) I actually implemented the selector to choose "downstream1" when the
: pin value is even and "downstream2" otherwise. [...]
To me, this seems like an unnecessary feature; I'd let the client pick
exactly 0 or 1.
: 2) I left the mux_passthrough_bus::switch_bus function in since it still
: seems like useful functionality for other subclasses.
Hmm. For what it's worth, I wouldn't have put the mux_passthrough
thingie into sid/include/ at all. It looks like a specialized enough
piece of code that I'd have kept it inside the source directory of
the appropriate glue component.
: OK to commit?
Sure; up to you if you want to take my mild objections into consideration.
- FChE
PGP signature