This is the mail archive of the
rda@sources.redhat.com
mailing list for the rda project.
PATCH: rda/unix/thread-db.c doc fixes
- From: Jim Blandy <jimb at redhat dot com>
- To: rda at sources dot redhat dot com
- Date: 22 Sep 2004 14:28:18 -0500
- Subject: PATCH: rda/unix/thread-db.c doc fixes
Committed as obvious.
2004-09-22 Jim Blandy <jimb@theseus.home>
* thread-db.c (thread_db_open, thread_db_get_gen): Doc fixes.
Index: rda/unix/thread-db.c
===================================================================
RCS file: /cvs/cvsfiles/devo/rda/unix/thread-db.c,v
retrieving revision 1.19
diff -c -p -r1.19 thread-db.c
*** rda/unix/thread-db.c 18 May 2004 06:12:54 -0000 1.19
--- rda/unix/thread-db.c 22 Sep 2004 19:15:47 -0000
*************** thread_db_dlopen (void)
*** 831,837 ****
/* Function: thread_db_open
Open a channel to the child's thread library.
! Returns: -1 for failure, 0 for success
FIXME: closure.
FIXME: where should we be called from? We will not succeed
until the thread shlib is loaded. The call from attach will not
--- 831,837 ----
/* Function: thread_db_open
Open a channel to the child's thread library.
! Returns: -1 for success, 0 for failure
FIXME: closure.
FIXME: where should we be called from? We will not succeed
until the thread shlib is loaded. The call from attach will not
*************** thread_db_get_gen (struct gdbserv *serv)
*** 1049,1055 ****
{
/* So far we've matched "qSymbol::". We're looking at either
form #1 ("qSymbol::", open a symbol lookup session), or
! form #2 ("qSymbol::<name>", a reply that "this symbol is
not defined". */
len = gdbserv_input_bytes (serv, tempname, sizeof (tempname));
--- 1049,1055 ----
{
/* So far we've matched "qSymbol::". We're looking at either
form #1 ("qSymbol::", open a symbol lookup session), or
! form #3 ("qSymbol::<name>", a reply that "this symbol is
not defined". */
len = gdbserv_input_bytes (serv, tempname, sizeof (tempname));
*************** thread_db_get_gen (struct gdbserv *serv)
*** 1062,1069 ****
}
else
{
! /* Form #2, this symbol not currently defined.
! Nothing to do, since we already have it marked undefined. */
}
}
else if (gdbserv_input_hex_ulong (serv, &tempval) >= 0 &&
--- 1062,1071 ----
}
else
{
! /* Form #3, this symbol not currently defined. Nothing
! to do, since we marked it REQUESTED when we sent it,
! and lookup_cached_symbol treats REQUESTED like
! UNDEFINED. */
}
}
else if (gdbserv_input_hex_ulong (serv, &tempval) >= 0 &&
*************** thread_db_get_gen (struct gdbserv *serv)
*** 1071,1077 ****
(len = gdbserv_input_bytes (serv, tempname, sizeof (tempname)))
> 0)
{
! /* Message contains a symbol and a value (form #3). */
tempname[len] = '\0';
add_symbol_to_list (tempname, (paddr_t) tempval, DEFINED);
--- 1073,1079 ----
(len = gdbserv_input_bytes (serv, tempname, sizeof (tempname)))
> 0)
{
! /* Message contains a symbol and a value (form #2). */
tempname[len] = '\0';
add_symbol_to_list (tempname, (paddr_t) tempval, DEFINED);