This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] common/math_errf.c: Enable compilation of __math_oflowf


On Mon, Jul 29, 2019 at 3:58 AM Corinna Vinschen <vinschen@redhat.com>
wrote:

> On Jul 26 14:39, joel@rtems.org wrote:
> > From: Joel Sherrill <joel@rtems.org>
> >
> >       This resolved linking errors when using methods such as
> >       expm1().
> > ---
> >  newlib/libm/common/math_errf.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
>
> Ok, please push.
>

Pushed. Thanks.

It seems as though a set of tests which invoke a single method and just link
(not execute) would have been sufficient to catch this.  RTEMS has tests
which
ensure the signatures matches POSIX but they don't link to ensure all the
supporting symbols are satisfied. Looks like something to put on the todo
list.

--joel

>
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]