This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix vfwscanf(3) assignment suppression flag handling bug

From: Corinna Vinschen <vinschen at redhat dot com>
To: Lucio Andrés Illanes Albornoz <lucio at lucioillanes dot de>
Cc: newlib at sourceware dot org
Date: Mon, 3 Jun 2019 10:41:26 +0200
Subject: Re: [PATCH] Fix vfwscanf(3) assignment suppression flag handling bug
References: <e9aca8f1-f199-8378-83dd-7de0ae079e29@lucioillanes.de>
Reply-to: newlib at sourceware dot org

On Jun  1 10:33, Lucio Andrés Illanes Albornoz wrote:
> newlib's vfwscanf(3) (or specifically, __SVFWSCANF_R()) fails to correctly set
> the assignment-suppressing character (`*') flag[1] which, when present in the
> formatting string, results in undefined behaviour comprising retrieving and
> dereferencing a pointer that was not supplied by the caller as such or at all.
> When compared to the vfscanf(3) implementation, this would appear to be over
> the missing goto match_failure statement preceded by the flags test seen below.
> Hence, this patch (re)introduces it.
> 
> [1] <http://pubs.opengroup.org/onlinepubs/009695399/functions/fwscanf.html>

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH] Fix vfwscanf(3) assignment suppression flag handling bug
  - From: Lucio Andrés Illanes Albornoz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]