This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
RE: [PATCH] Arm - exceptions stack pointer initialization hook
Hi Alex,
Sorry for the delay, Richard is still out, I’ll ask him to review them as soon as he’s back in!
Kind Regards,
Tamar
From: Alexander Fedotov <alfedotov@gmail.com>
Sent: Monday, February 11, 2019 16:33
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: Newlib <newlib@sourceware.org>; Richard Earnshaw <Richard.Earnshaw@arm.com>; nd <nd@arm.com>
Subject: Re: [PATCH] Arm - exceptions stack pointer initialization hook
Ping
On Wed, 6 Feb 2019 at 16:12, Tamar Christina <Tamar.Christina@arm.com<mailto:Tamar.Christina@arm.com>> wrote:
Hi Alex,
Yes, I made an ticket to go look at this, It doesn't have any of the THUMB changes either so it's way way out of date.
But I need to wait for Richard to ask if they really should be exact copies.
Cheersm
Tamar
> -----Original Message-----
> From: Alexander Fedotov <alfedotov@gmail.com<mailto:alfedotov@gmail.com>>
> Sent: Wednesday, February 6, 2019 12:49
> To: Tamar Christina <Tamar.Christina@arm.com<mailto:Tamar.Christina@arm.com>>
> Cc: Newlib <newlib@sourceware.org<mailto:newlib@sourceware.org>>; Richard Earnshaw
> <Richard.Earnshaw@arm.com<mailto:Richard.Earnshaw@arm.com>>; nd <nd@arm.com<mailto:nd@arm.com>>
> Subject: Re: [PATCH] Arm - exceptions stack pointer initialization hook
>
> Hi Tamar
> Ok, I will update patches a bit later. It seems crt0.S in libgloss and libc aren't
> up to sync long time. I don't see semihosting v2 changes there as well...
> Alex
>
> On Wed, Feb 6, 2019 at 2:32 PM Tamar Christina <Tamar.Christina@arm.com<mailto:Tamar.Christina@arm.com>>
> wrote:
> >
> > Hi All,
> >
> > As a side note,
> >
> > As Richard mentioned any changes here should be mirrored to the
> newlib/libc/sys/arm/* folder.
> >
> > Thanks,
> > Tamar
> >
> > > -----Original Message-----
> > > From: Tamar Christina
> > > Sent: Tuesday, February 5, 2019 12:42
> > > To: Alexander Fedotov <alfedotov@gmail.com<mailto:alfedotov@gmail.com>>; Newlib
> > > <newlib@sourceware.org<mailto:newlib@sourceware.org>>; Richard Earnshaw
> <Richard.Earnshaw@arm.com<mailto:Richard.Earnshaw@arm.com>>
> > > Cc: nd <nd@arm.com<mailto:nd@arm.com>>
> > > Subject: RE: [PATCH] Arm - exceptions stack pointer initialization
> > > hook
> > >
> > > Hi all,
> > >
> > > This patch looks good to me as well (but I'm not a maintainer so
> > > can't approve), It's mostly just refactoring, the only functional
> > > change is that _exceptions_stack_init is now also called in the case
> > > of semihosting, which I think is OK as well, but would like Richard to
> quickly confirm.
> > >
> > > I'll run it by him when he's back,
> > >
> > > Thanks,
> > > Tamar
> > >
> > > > -----Original Message-----
> > > > From: Alexander Fedotov <alfedotov@gmail.com<mailto:alfedotov@gmail.com>>
> > > > Sent: Tuesday, February 5, 2019 10:41
> > > > To: Newlib <newlib@sourceware.org<mailto:newlib@sourceware.org>>; Richard Earnshaw
> > > > <Richard.Earnshaw@arm.com<mailto:Richard.Earnshaw@arm.com>>; Tamar Christina
> > > <Tamar.Christina@arm.com<mailto:Tamar.Christina@arm.com>>;
> > > > Alexander Fedotov <alfedotov@gmail.com<mailto:alfedotov@gmail.com>>
> > > > Subject: Re: [PATCH] Arm - exceptions stack pointer initialization
> > > > hook
> > > >
> > > > Eventually I want to push all the changes from there:
> > > > 1.
> > > >
> > >
> https://github.com/alfedotov/newlib/commit/58ce6f19eb457a2c2b700dfe7
> > > 1
> > > > 798ef09ba63e10
> > > > 2.
> > > >
> > >
> https://github.com/alfedotov/newlib/commit/4cabb1f7587304d1c891da59b
> > > > d1871fcc8668ae5
> > > > 3.
> > > >
> > >
> https://github.com/alfedotov/newlib/commit/7d38977d4baaecb43fc47f34d
> > > 7
> > > > 21a3df23334400
> > > > 4.
> > > >
> > >
> https://github.com/alfedotov/newlib/commit/e8f094f6729ade24a149d1d68
> > > 1
> > > > 6876e7ccadae0a
> > > >
> > > > General idea behind of all these changes is to provide hooks for
> > > > flexibility (including semihosting when debug tap is used) and
> > > > improve readability of existing crt0 code. At the moment it is a total
> mess of ifdefs...
> > > >
> > > > Alex
> > > >
> > > > On Tue, Feb 5, 2019 at 1:32 PM Corinna Vinschen
> > > > <vinschen@redhat.com<mailto:vinschen@redhat.com>>
> > > > wrote:
> > > > >
> > > > > On Feb 3 22:59, Alexander Fedotov wrote:
> > > > > > Please find attached patch that adds new hook
> > > > > > "_exceptions_stack_init". Hook is defined as "weak" to give
> > > > > > user ability to override by it's own implementation.
> > > > > > Also added new macro for .fnstart and .fnend to improve readability.
> > > > > >
> > > > > > Alex
> > > > >
> > > > > Any ARM person to review this patch and the patches from
> > > > > https://sourceware.org/ml/newlib/2019/msg00028.html?
> > > > >
> > > > >
> > > > > Thanks,
> > > > > Corinna
> > > > >
> > > > > --
> > > > > Corinna Vinschen
> > > > > Cygwin Maintainer
> > > > > Red Hat
> > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > AF
>
>
>
> --
> Best regards,
> AF
--
Best regards,
AF