RE: [PATCH] Arm - exceptions stack pointer initialization hook

[Tamar Christina <Tamar dot Christina at arm dot com>]

Hi all,

This patch looks good to me as well (but I'm not a maintainer so can't approve), It's mostly just refactoring,
the only functional change is that _exceptions_stack_init is now also called in the case of semihosting,
which I think is OK as well, but would like Richard to quickly confirm.

I'll run it by him when he's  back,

Thanks,
Tamar

> -----Original Message-----
> From: Alexander Fedotov <alfedotov@gmail.com>
> Sent: Tuesday, February 5, 2019 10:41
> To: Newlib <newlib@sourceware.org>; Richard Earnshaw
> <Richard.Earnshaw@arm.com>; Tamar Christina
> <Tamar.Christina@arm.com>; Alexander Fedotov <alfedotov@gmail.com>
> Subject: Re: [PATCH] Arm - exceptions stack pointer initialization hook
> 
> Eventually I want to push all the changes from there:
> 1.
> https://github.com/alfedotov/newlib/commit/58ce6f19eb457a2c2b700dfe71
> 798ef09ba63e10
> 2.
> https://github.com/alfedotov/newlib/commit/4cabb1f7587304d1c891da59b
> d1871fcc8668ae5
> 3.
> https://github.com/alfedotov/newlib/commit/7d38977d4baaecb43fc47f34d7
> 21a3df23334400
> 4.
> https://github.com/alfedotov/newlib/commit/e8f094f6729ade24a149d1d681
> 6876e7ccadae0a
> 
> General idea behind of all these changes is to provide hooks for flexibility
> (including semihosting when debug tap is used) and improve readability of
> existing crt0 code. At the moment it is a total mess of ifdefs...
> 
> Alex
> 
> On Tue, Feb 5, 2019 at 1:32 PM Corinna Vinschen <vinschen@redhat.com>
> wrote:
> >
> > On Feb  3 22:59, Alexander Fedotov wrote:
> > > Please find attached patch that adds new hook
> > > "_exceptions_stack_init". Hook is defined as "weak" to give user
> > > ability to override by it's own implementation.
> > > Also added new macro for .fnstart and .fnend to improve readability.
> > >
> > > Alex
> >
> > Any ARM person to review this patch and the patches from
> > https://sourceware.org/ml/newlib/2019/msg00028.html?
> >
> >
> > Thanks,
> > Corinna
> >
> > --
> > Corinna Vinschen
> > Cygwin Maintainer
> > Red Hat
> 
> 
> 
> --
> Best regards,
> AF