This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Jan 22 20:51, Jozef Lawrynowicz wrote: > On Wed, 16 Jan 2019 09:50:00 +0100 > Corinna Vinschen <vinschen@redhat.com> wrote: > > > Your patch was fine, just the problem of stopping to export a symbol > > from Cygwin worried me. > > > > We don't want to break an older application to run just because we > > removed a function from the DLL. On reading your mail and further > > reading up on matherr it seems this isn't really a problem. > > > > If we *really* get a complaint on the Cygwin mailing list, we can > > resurrect matherr just as an exportable symbol for Cygwin. > > Ok, sounds good. > > > Can you please resend your patch? > > I've attached the original patch (0001-*), but also 3 further patches which > make some additional improvements to the float math functions. > > 0002-Newlib-Remove-HUGE_VAL-definition-from-libm-math-fun.patch > This patch removes the definitions of HUGE_VAL from some of the float math > functions. HUGE_VAL is defined in newlib/libc/include/math.h, so it is not > necessary to have a further definition in the math functions. > > 0003-Newlib-Use-HUGE_VALF-instead-of-HUGE_VAL-in-single-p.patch > This patch replaces instances of "(float).*HUGE_VAL" with a direct usage of > HUGE_VALF, which is also defined in math.h. > > 0004-Newlib-Use-nanf-instead-of-nan-in-single-precision-f.patch > This patch further reduces code size for a few single-precision float math > functions, by using nanf() instead of nan() where required. > > I've regtested the patches with the GCC testsuite for arm-unknown-eabi, and I > built Cygwin and regtested it with "make check". All patches applied. I added a bit of your text to your patch description, just the headline is a bit terse. It would be nice for future patches to read the description not only in the mail, but also in the patch itself :) Oh, and I added a bit of Cygwin version paraphernalia to your first patch. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat
Attachment:
signature.asc
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |