Re: [PATCH v2] Make some standard open() flags visible

[Corinna Vinschen <vinschen at redhat dot com>]

On Oct 11 07:35, Sebastian Huber wrote:
> On 10/10/2018 17:00, Corinna Vinschen wrote:
> > > +/* POSIX-1.2008 specific flags */
> > > +#if __POSIX_VISIBLE >= 200809
> > > +#define	O_CLOEXEC	_FNOINHERIT
> > > +#define	O_NOFOLLOW	_FNOFOLLOW
> > > +#define	O_DIRECTORY	_FDIRECTORY
> > > +#define	O_EXEC		_FEXECSRCH
> > > +#define	O_SEARCH	_FEXECSRCH
> > > +#endif
> > > +
> > > +#if __BSD_VISIBLE
> > > +#define	O_DIRECT	_FDIRECT
> > > +#endif
> > > +
> > > +#if defined (__CYGWIN__)
> > >   #define O_BINARY	_FBINARY
> > >   #define O_TEXT		_FTEXT
> > >   #define O_DSYNC         _FSYNC
> > >   #define O_RSYNC         _FSYNC
> > > -#define O_EXEC          _FEXECSRCH
> > > -#define O_SEARCH        _FEXECSRCH
> > > -
> > > -/* POSIX-1.2008 specific flags */
> > > -#if __POSIX_VISIBLE >= 200809
> > Doesn't that require to #define _POSIX_C_SOURCE 200809L in your
> > libc/posix/opendir.c patch?
> > 
> 
> This POSIX standard is visible by default:
> 
> echo "#include <sys/cdefs.h>" > test.c
> arm-rtems5-gcc -E test.c -o - -Wp,-dD | grep VISIBLE
> #define __ATFILE_VISIBLE 1
> #define __BSD_VISIBLE 1
> #define __GNU_VISIBLE 0
> #define __ISO_C_VISIBLE 2011
> #define __LARGEFILE_VISIBLE 0
> #define __MISC_VISIBLE 1
> #define __POSIX_VISIBLE 200809
> #define __SVID_VISIBLE 1
> #define __XSI_VISIBLE 0

Oh, right.  _DEFAULT_SOURCE implies POSIX 200809.  Sorry for the noise.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature