This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Improve sincosf comments

From: Corinna Vinschen <vinschen at redhat dot com>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
Cc: "newlib at sourceware dot org" <newlib at sourceware dot org>, nd <nd at arm dot com>
Date: Mon, 13 Aug 2018 09:31:10 +0200
Subject: Re: [PATCH] Improve sincosf comments
References: <DB5PR08MB10307A877D9E9FF9B1FC2A0283240@DB5PR08MB1030.eurprd08.prod.outlook.com>
Reply-to: newlib at sourceware dot org

On Aug 10 11:34, Wilco Dijkstra wrote:
> Improve comments in sincosf implementation to make the code easier
> to understand. Build succeeds - no changes in generated code.
> 
> ChangeLog:
> 2018-08-10 Wilco Dijkstra  <wdijkstr@arm.com>
> 
>         * newlib/libm/common/cosf.c (cosf): Improve comment.
>         * newlib/libm/common/sincosf.h (pi63): Rename to pi63.
>         (sincos_t): Comment struct members.
>         (reduce_fast): Improve comments.
>         (reduce_large): Likewise.
>         * newlib/libm/common/sincosf.c (sincosf): Improve comment.
>         * newlib/libm/common/sinf.c (sinf): Likewise.
> --

Patch is ok, but we can really drop the CVS-style ChangeLogs now.  A
nice explanation of the changes would be more helpful, including a word
on the name change pi64 -> pi63.

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- Re: [PATCH] Improve sincosf comments
  - From: Wilco Dijkstra

References:
- [PATCH] Improve sincosf comments
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]