Re: [PATCH] fix llrint and lrint for 52 <= exponent <= 62

[Corinna Vinschen <vinschen at redhat dot com>]

On May 29 14:55, Matthias J. Kannwischer wrote:
> Hi Corinna, 
> 
> sure, it's attached - sorry for that. 
> 
> Best, 
> 
> Matthias 
> 
> On Tue, May 29, 2018 at 03:25:21PM +0200, Corinna Vinschen wrote:
> > Hi Matthias,
> > 
> > On May 14 14:38, Matthias J. Kannwischer wrote:
> > > lrint and llrint produce wrong results if the exponent is between 52 and 62. 
> > > e.g. llrint(2.308393893084546048E18) returns 146666059061806080 instead of 2308393893084546048. 
> > > Can you confirm this?
> > > I've tracked this down to two mistakes in s_llrint.c/s_lrint.c (one missing 0 and one uint32 overflow), see patch below. 
> > > 
> > > Cheers, 
> > > Matthias
> > > [...]
> > 
> > Looks right to me, but can you resend the patch as attachment, please?
> > Your MUA apparently replaced tabs with spaces.
> > 
> > 
> > Thanks,
> > Corinna

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature