This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Mar 13 14:05, Can Finner wrote: > On Tue, Mar 13, 2018 at 1:49 PM, Thomas Wolff <towo@towo.net> wrote: > > On 13.03.2018 13:49, Corinna Vinschen wrote: > >> On Mar 13 12:02, Can Finner wrote: > >>> On Tue, Mar 13, 2018 at 11:21 AM, Can Finner <can.finner@gmail.com> > >>> wrote: > >>>> On Tue, Mar 13, 2018 at 10:40 AM, Corinna Vinschen <vinschen@redhat.com> > >>>> wrote: > >>>>> On Mar 13 10:33, Can Finner wrote: > >>>>>> This patch breaks arm-none-eabi cross toolchain build with below error > >>>>>> message: > >>>>>> > >>>>>> [...] > >>>>>> /data/.../newlib-cygwin/newlib/libc/ctype/categories.c:5:17: error: > >>>>>> width of 'cat' exceeds its type > >>>>>> enum category cat: 11; > >>>>>> ^~~ > >>>>> > >>>>> I don't understand this error. Why is an enum < 11 bits?!? > >>>> > >>>> To be honest, I don't either. Will collect more information about this. > >>> > >>> So it looks like arm ABI requires -fshort-enums for bare-metal > >>> toolchain, which will pack enum type into small int-type. > >>> In this case, the enum category as below has fewer than 256 entries in > >>> call cases? > >>> enum category { > >>> #include "categories.cat" > >>> }; > >> > >> Have a look at the file, it has barely 32 categories, so even a :5 > >> would suffice. > >> > >> Thomas, what was the idea here? 11 + 21 = 32, so was it just to > >> fill the struct? > > > > Yes, and to keep the Unicode value right-aligned. But 8/24 will do alike, > > please change it so. > Thanks for clarification, I will prepare a change. Never mind, I pushed a patch. Please give it a try. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat
Attachment:
signature.asc
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |