This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] implicit Unicode data tables generation
On 13.03.2018 11:46, Corinna Vinschen wrote:
On Mar 12 20:32, Thomas Wolff wrote:
Am 12.03.2018 um 15:21 schrieb Corinna Vinschen:
A build dependency to unicode-ucd should not be required. Why not have
automatic build rules which are simply skipped if the file doesn't
exist? So somebody can download the file and the rules do the rest?
It's not *that* important, but a nice feature.
The easiest way would be that the mkunidata scripts just ignore the missing
files, like in the patch attached.
On the other hand, in my original scripts I had the additional fallback
option to download them from unicode.org on demand.
If that's acceptable in a build process, I could add that back in.
Or just drop those rules and stay explicit?
Implicit would be nice, it's not actually a hard requirement.
We must not rely on system-installed files outside the source tree,
build tree or outside the toolchain.
That's why my patch yesterday would ignore missing of the files.
Please provide a patch removing any ln to files under /usr/share, etc.
Is dependency to one more cygwin package (like obscure ones like "cocom"
already) a problem?
Is "ln -s" the culprit, so would "cp" be OK?
The explicit rules add a rule to download the Unicode.txt file into the
src tree. That's the only file we may rely on. If it doesn't exist,
an implicit rule should not break the build.
Well, my mentioned patch wouldn't break it anymore. I can tweak the
script further to your preference, but if a solution would involve
further Makefile changes (like "phony" usage), I would ask you to do
that. Adding to the previous build problem I had, it may have been
caused after I recreated the target dir Makefile locally with "make
Makefile", in order to avoid the 2-hours-turnaround cycle that I'd
otherwise have with building cygwin.
If we don't agree otherwise, just drop the "implicit" rules patch.
Thanks
Thomas