Re: [PATCH 3/6] generated character data for libc/ctype

[Thomas Wolff <towo at towo dot net>]

Am 09.03.2018 um 08:11 schrieb Thomas Wolff:
> Am 08.03.2018 um 23:05 schrieb Thomas Wolff:
> > Am 08.03.2018 um 09:04 schrieb Corinna Vinschen:
> > > On Mar  8 00:20, Thomas Wolff wrote:
> > > >  From 15999d30c011be9041821456d23807249981dd86 Mon Sep 17 00:00:00 
> > > > 2001
> > > > From: Thomas Wolff <towo@towo.net>
> > > > Date: Sun, 25 Feb 2018 17:11:44 +0100
> > > > Subject: [PATCH 3/6] remove hard-coded character data
> > > Sorry, but no.  ... don't delete and re-introduce files, just overwrite
> > > them with the new code, for sake of a sane history.
> > The only reason for the split was that I recall a 64KB mail size
> > limitation on this mailing list;
> > given that git format-patch quotes all deleted lines, this would have
> > been exceeded,
> > so how should we handle this? Would format-patch option -D be
> > acceptable? Can you drop that limitation?
> >
> > > Also, these two patches(*) should get a descriptive text in the git 
> > > log.
> > > Especially the fact that it turns around the calling order is worth a
> > > couple of words.
> > OK.
> Extended commit description:
>
> The tow* functions use an included case conversion table which can be
> generated from Unicode data.
> The isw* functions use a character categories table (provided by 
> categories.c)
> which can be generated from Unicode data.
> Delegation between current-locale and locale-dependent functions was
> reverted towards the generic locale-dependent functions; this is however
> only relevant on systems with non-Unicode wide character locales,
> thus not on Cygwin.
>
> > > Thanks,
> > > Corinna
> > >
> > > (*) ...which should actually be only one as outlined above. The
> > >      easiest way to accomplish that is probably an interactive rebase
> > >      with squashing the second patch into the first.
> > As I'm not a master at git fiddling, for me the easiest way is rather 
> > poking the files into a fresh git clone...
Here is the updated common ctype patch, replacing previous patches 3/6 
and 4/6.
Thomas


---
Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft.
https://www.avast.com/antivirus

Attachment: 0034-use-generated-character-data.patch
Description: Text document