This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patches] [PATCH 1/2] RISC-V: Fix alignment issue in sigjmp_buf


On 01/18/2018 10:58 AM, Palmer Dabbelt wrote:
On Wed, 17 Jan 2018 19:04:20 PST (-0800), Kito Cheng wrote:
This patch fix a potential mis-alignment issue in sigjump_buf, load a
double floating value required 8 bytes align, but we just align to
size of long, it's may cause mis-align memory access in rv32imafd.
This looks good to me.  Do you want me to co-maintain the RISC-V newlib port? IIRC you're the only maintainer, which can be a lot of work.

I already have write after approval access for newlib, and have been reviewing pull requests in the github riscv-newlib project. This patch was part of
    https://github.com/riscv/riscv-newlib/pull/30/
I also checked in the last set of patches that Kito sent. If we need a co-maintainer, it might make more sense for it to be me.

Jim


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]