Re: Adding Methods related to inttypes.h

[Sebastian Huber <sebastian dot huber at embedded-brains dot de>]

On 13/06/17 21:03, aditya upadhyay wrote:

> Hello Developers,
>
> I have ported the methods what are declared inside the inttypes.h
> header file from freebsd. I am requesting you to please review the
> code.
>
> I am not able to push the code of ccoshl.c in my forked repo. It is
> saying fatal error. I do not know how to apply the signature.asc file.
> Please have a look on my issue.
>
>
> Thanks & Regards,
> Aditya Upadhyay
>
> 0001-Porting-the-methods-declared-inside-inttypes.h-from-.patch
>
>
>  From b1eca6d665fc82eead745c49be9c7ccb27719483 Mon Sep 17 00:00:00 2001
> From: Aditya Upadhyay<aadit0402@gmail.com>
> Date: Wed, 14 Jun 2017 00:26:39 +0530
> Subject: [PATCH] Porting the methods declared inside inttypes.h from freebsd.
>
> ---
>   newlib/libc/Makefile.am          |   4 +-
>   newlib/libc/inttypes/Makefile.am |  24 +++++++
>   newlib/libc/inttypes/imaxabs.c   |  44 ++++++++++++
>   newlib/libc/inttypes/imaxdiv.c   |  53 ++++++++++++++
>   newlib/libc/inttypes/strtoimax.c | 144 +++++++++++++++++++++++++++++++++++++
>   newlib/libc/inttypes/strtoumax.c | 135 ++++++++++++++++++++++++++++++++++
>   newlib/libc/inttypes/wcstoimax.c | 151 +++++++++++++++++++++++++++++++++++++++
>   newlib/libc/inttypes/wcstoumax.c | 144 +++++++++++++++++++++++++++++++++++++

These functions should probably go into "newlib/libc/stdlib" just like 
on FreeBSD and NetBSD. Where does this "inttypes" directory come from?

[...]
> diff --git a/newlib/libc/inttypes/imaxabs.c b/newlib/libc/inttypes/imaxabs.c
> new file mode 100644
> index 0000000..e803869
> --- /dev/null
> +++ b/newlib/libc/inttypes/imaxabs.c
> @@ -0,0 +1,44 @@
> +/*-
> + *  Copyright (c) 2001 Mike Barcroft<mike@FreeBSD.org>
> + *  All rights reserved.
> + *
> + *  Redistribution and use in source and binary forms, with or without
> + *  modification, are permitted provided that the following conditions
> + *  are met:
> + *  1. Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + *  2. Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in the
> + *     documentation and/or other materials provided with the distribution.
> + *
> + *  THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> + *  ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + *  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + *  ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> + *  FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> + *  DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> + *  OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> + *  HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> + *  LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> + *  OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> + *  SUCH DAMAGE.
> + */
> +
> +#if HAVE_CONFIG_H
> +#include "config.h"
> +#endif

We don't have this HAVE_CONFIG_H stuff in Newlib.

Please do not change the format for these files (white space changes). 
For imports from FreeBSD please use the SVN checkout to get the revision 
numbers. This makes it easier to figure out the origin of files.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.