Re: [PATCH] nl_langinfo: Add NL_LOCALE_NAME macro

[Eric Blake <eblake at redhat dot com>]

On 01/20/2017 03:33 AM, Corinna Vinschen wrote:
>>
>> * libc/include/langinfo.h (NL_LOCALE_NAME): New macro
>> * libc/locale/nl_langinfo.c (nl_langinfo_l): Expose locale names
>> of a locale_t's category components.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
> 
> Thanks for this patch but...  did you actually try building with your
> patch?  I'm getting undefined references to NL_LOCALE_NAME in
> nl_langinfo.c.

Urrgh - I've got to quit changing patches after I test them. I added the
__GNU_SOURCE guard in the header at the last minute, after one last
check of whether namespace pollution was allowed by default.

> 
> The reason is a missing #define _GNU_SOURCE.
> 
> I added this to your patch and pushed it.

Thanks for fixing up after me.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature