Re: Better FreeBSD compatibility

[Corinna Vinschen <vinschen at redhat dot com>]

On Apr  7 09:50, Sebastian Huber wrote:
> On 07/04/16 09:30, Corinna Vinschen wrote:
> >On Apr  7 09:21, Corinna Vinschen wrote:
> >>On Apr  6 12:04, Sebastian Huber wrote:
> >>>Hello,
> >>>
> >>>in RTEMS we use the FreeBSD network stack and other components. I would like
> >>>to make some Newlib headers (e.g. <sys/tyeps.h>, <sys/param.h> and
> >>><sys/time.h>) more compatible to FreeBSD so that we can use them directly.
> >>>This involves changes like this:
> >>>
> >>>Change internal type from x to y, e.g. _off_t to __off_t.
> >>>
> >>>Change type define guard from x to y. e.g. __clockid_t_defined to
> >>>_CLOCKID_T_DECLARED.
> >>As long as you test that your changes don't break Cygwin it should
> >>be ok.
> >>
> >>However, how sure can we be that Cygwin is the *only* target using
> >>internal types outside the newlib tree?
> >s/Cygwin is the *only* target/Cygwin and RTEMS are the *only* targets/
> >
> >What about something like
> >
> >   #define __off_t _off_t
> >
> >or
> >
> >   typedef _off_t __off_t;
> >
> >thus adding the missing type instead of changing it?
> 
> Ok, for types I will add a typedef for the FreeBSD type and keep existing
> types.
> 
> What about the internal guard defines?

It's ok to rename internal guards, but please make sure a change doesn't
break some target-specific headers, including Cygwin headers.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature