Re: [PATCH] Add simple versions of random() and srandom()

[Joel Sherrill <joel dot sherrill at oarcorp dot com>]

On 3/23/2016 12:45 PM, Yaakov Selkowitz wrote:
> On 2016-03-23 12:38, Joel Sherrill wrote:
> > --- a/newlib/libc/include/stdlib.h
> > +++ b/newlib/libc/include/stdlib.h
> > @@ -226,6 +226,12 @@ unsigned short *
> >    _VOID  _EXFUN(srand48,(long));
> >    _VOID  _EXFUN(_srand48_r,(struct _reent *, long));
> >    #endif /* __SVID_VISIBLE || __XSI_VISIBLE */
> > +#if __SVID_VISIBLE || __XSI_VISIBLE >= 4 || __BSD_VISIBLE
>
> Please review my previous comment on this.

Is this the desired guard?

#if __MISC_VISIBLE || __XSI_VISIBLE >= 500
 
> > +ANSI_SYNOPSIS
> > +	#define _XOPEN_SOURCE 500
> > +	#include <stdlib.h>
> > +	long int random(void);
> > +	void srandom(unsigned int <[seed]>);
>
> This doesn't match the header guard, nor does it account for the
> multiple options.

So how is the || documented in this format?

> > +PORTABILITY
> > +<<random>> is required by POSIX.
>
> Actually, it's XSI.

OK.

--joel