Re: [PATCH] newlib/configure.host: Turn off sti/cli for i386 setjmp for i386-rtems*

[Corinna Vinschen <vinschen at redhat dot com>]

On Feb 26 12:35, Jeff Johnston wrote:
> 
> 
> ----- Original Message -----
> > On Feb 26 09:34, Joel Sherrill wrote:
> > > On 2/26/2016 9:26 AM, Corinna Vinschen wrote:
> > > >On Feb 26 04:54, Joel Sherrill wrote:
> > > >>On 2/26/2016 4:44 AM, Corinna Vinschen wrote:
> > > >>>Would it make sense to enable _I386MACH_ALLOW_HW_INTERRUPTS by default
> > > >>>on x86/x86_64?
> > > >>
> > > >>I can't see any downside. I spot checked other ports and no other port
> > > >>seemed to have comparable code. I would be OK with that. Where is it
> > > >>defaulted?
> > > >
> > > >I thought changing the definition from _I386MACH_ALLOW_HW_INTERRUPTS to,
> > > >e.g, _I386MACH_DISABLE_HW_INTERRUPTS wouldn't hurt, as in the patch
> > > >below.
> > > >
> > > >However, we might have to make sure how to handle explicitly mentioned
> > > >ix86 systems (rdos, sco, netware).  I know basically nothing about
> > > >these.
> > > 
> > > I don't know about rdos but sco and netware would be running setjmp/longjmp
> > > in user space and thus not be able to us the instructions.
> > > 
> > > Seems as though they would have complained if there were any users. :)
> > 
> > You have a point there.  We may want to add -D_I386MACH_DISABLE_HW_INTERRUPTS
> > to rdos for backward compat and just skip it everywhere else.
> > 
> > Jeff, does that sound ok to you?  See the below patch suggestion.
> > 
> 
> Sure.  Please go ahead.

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature