Re: [PATCH v1 1/3] Feature test macro overhaul

[Corinna Vinschen <vinschen at redhat dot com>]

On Feb 12 07:59, Sebastian Huber wrote:
> Hello Yaakov,
> 
> its good that you keep the FreeBSD __*_VISIBLE defines in place, so
> that its still easy to use code from FreeBSD. At least for RTEMS this
> is important, since we use the network, USB and SD/MMC stack from
> FreeBSD.
> 
> I am not sure if its a good thing to do the feature checks differently
> in each C library. My approach would have been to us an existing
> mechanism and in case of errors report them to the upstream.

I'm also a bit concerned here.  It decouples us partially from upstream.
The changes don't look bad, mind, but it now looks a bit like a mix
between Glibc and FreeBSD.  Can we maintain this easily in future?


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature