Re: [PATCH] Make macro checks ARMv8-M baseline proof

[Corinna Vinschen <vinschen at redhat dot com>]

On Dec 16 16:57, Richard Earnshaw (lists) wrote:
> On 16/12/15 12:45, Thomas Preud'homme wrote:
> >         * arm/arm.h (THUMB_V7_V6M): Rename to ...
> >         (PREFER_THUMB): This.  Use ACLE macros __ARM_ARCH_ISA_ARM instead of
> >         __ARM_ARCH_6M__ to decide whether to define it.
> >         (THUMB_V7M_V6M): Delete.
> >         (THUMB1_ONLY): Define for Thumb-1 only targets.
> >         * arm/crt0.S: Use THUMB1_ONLY rather than __ARM_ARCH_6M__,
> >         !__ARM_ARCH_ISA_ARM rather than THUMB_V7M_V6M, and PREFER_THUMB rather
> >         than THUMB_V7_V6M.
> >         * arm/linux-crt0.c: Likewise.
> >         * arm/redboot-crt0.S: Likewise.
> >         * arm/swi.h: Likewise.
> >         * arm/trap.S: Likewise.
> > 
> 
> Some older versions of GCC only partially (at best) define the ACLE
> macros.  You can handle this by including acle-compat.h from
> newlib/libc/machine/arm.  However, I'm not exactly sure if it's possible
> to reach over directly from libgloss to the newlib source tree.
> 
> Jeff/Corinna: is this possible?  if so, what are the runes needed?
> Ideally acle-compat.h should not be installed since it's only intended
> to support building newlib.

I'm not overly familiar with libgloss, but I see various methods used.
See, for instance, the definitions of NEWLIB_CFLAGS and NEWLIB_LDFLAGS
in epiphany/Makefile.in.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpmlxCcIJ4Zc.pgp
Description: PGP signature