This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH, AARCH64] Optimized memset
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>
- Cc: Newlib Mailing List <newlib at sourceware dot org>
- Date: Thu, 30 Jul 2015 12:53:32 +0100
- Subject: Re: [PATCH, AARCH64] Optimized memset
- Authentication-results: sourceware.org; auth=none
- References: <000801d0b98f$96ad0e10$c4072a30$ at com> <7748F2F1-D474-475F-B7CE-29D6A009E835 at gmail dot com> <001601d0bb0e$319a81d0$94cf8570$ at com> <CAFqB+PydYPWdRxGWzJMe4muvL+Vd2PnepLR0An1WwAc4f-s6YA at mail dot gmail dot com> <002601d0c0a8$3d31d8a0$b79589e0$ at com>
On 17 July 2015 at 16:50, Wilco Dijkstra <wdijkstr@arm.com> wrote:
> It turns out there was a typo in this instruction due to testing for
> different zva values:
>
> and tmp1w, tmp1w, 4 (should be 15)
>
> As a result memset fails if you use a dz zva value other than the
> common setting of 64 bytes. With the change it correctly works with
> any legal setting, and aarch64_be-none-elf passes.
>
> Attached is the fixed version of the patch.
Wilco, Thanks for fixing this, committed.
Cheers /Marcus