This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Potential memory leak in argz_replace.c

From: David Stacey <drstacey at tiscali dot co dot uk>
To: newlib at sourceware dot org
Date: Mon, 01 Jun 2015 20:44:59 +0100
Subject: Re: [PATCH] Potential memory leak in argz_replace.c
Authentication-results: sourceware.org; auth=none
References: <554FC73E dot 8030803 at tiscali dot co dot uk> <20150527101617 dot GA7510 at calimero dot vinschen dot de> <556B6EC5 dot 7090006 at tiscali dot co dot uk> <20150601081052 dot GE4308 at calimero dot vinschen dot de>

On 01/06/15 09:10, Corinna Vinschen wrote:

Thanks but, uhm, that didn't quite work out:

   libc/argz/argz_replace.c: In function âargz_replaceâ:
   libc/argz/argz_replace.c:75:26: error: assignment makes integer from pointer without a cast [-Werror]
	 if(!(*argz_realloc = (char *)realloc(*argz, new_argz_len)))
			    ^
   libc/argz/argz_replace.c:80:12: error: assignment from incompatible pointer type [-Werror]
	 argz = argz_realloc;
	      ^
   cc1: all warnings being treated as errors

I fixed that and applied the patch.


Oh my, that's embarrassing! Thanks for fixing.

Dave.

References:
- [PATCH] Potential memory leak in argz_replace.c
  - From: David Stacey
- Re: [PATCH] Potential memory leak in argz_replace.c
  - From: Corinna Vinschen
- Re: [PATCH] Potential memory leak in argz_replace.c
  - From: David Stacey
- Re: [PATCH] Potential memory leak in argz_replace.c
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]