Re: [PATCH] qsort_r

[Corinna Vinschen <vinschen at redhat dot com>]

Hi Yaakov,

On Dec  4 19:14, Yaakov Selkowitz wrote:
> Patch attached.

Thanks for the patch.  It looks good, I have just one minor nit:

> Index: libc/search/bsd_qsort_r.c
> ===================================================================
> RCS file: libc/search/bsd_qsort_r.c
> diff -N libc/search/bsd_qsort_r.c
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ libc/search/bsd_qsort_r.c	5 Dec 2014 00:53:33 -0000
> @@ -0,0 +1,2 @@
> +#define I_AM_BSD_QSORT_R
> +#include "qsort.c"
[...]
> Index: libc/search/qsort_r.c
> ===================================================================
> RCS file: libc/search/qsort_r.c
> diff -N libc/search/qsort_r.c
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ libc/search/qsort_r.c	5 Dec 2014 00:53:33 -0000
> [...]
> +#define I_AM_QSORT_R
> +#include "qsort.c"

The FreeBSD source uses I_AM_QSORT_R for the BSD variant.  I understand
that we're going to prefer the GNU variant over the BSD variant, but for
ease of maintainance it might be better in the long run to stick to the
BSD macro name for the BSD variant, and to use I_AM_GNU_QSORT_R for the
GNU variant.  The less diffence to the upstream source, the better.

With that change, ok to apply.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgp3OKFcwie3o.pgp
Description: PGP signature