This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH,MIPS 3/3] Setting of status register based on .MIPS.abiflags

Steve Ellcey <Steve.Ellcey@imgtec.com> writes:
> > On Tue, 2014-11-18 at 12:26 +0000, Matthew Fortune wrote:
> >
> > > +	/* Read MIPS_abiflags structure and set status/config registers
> > > +	   accordingly.  */
> > > +	.weak	__MIPS_abiflags_start
> > > +	.weak	__MIPS_abiflags_end
> > > +	LA	(t0,__MIPS_abiflags_start)
> > > +	LA	(t1,__MIPS_abiflags_end)
> > > +	addiu	t1,t1,-24
> > > +	move	v0,zero			/* Mask for C0_SR.  */
> > > +	bne	t0,t1,1f
> >
> > I would add a bit more to the comment here to explicitly say that we
> > are checking to see if the abiflags structure is defined and jumping
> to '1f'
> > if it is not.
> >
> > Other then that the patch looked OK to me.
> 
> OK, I agree the test is a bit odd. I'll send an updated patch in the
> next day or so.

Updated patch attached with a comment at the appropriate place. Let me
know if you think anything else needs work.

Thanks,
Matthew

Attachment: 0003-Setting-of-status-register-based-on-.MIPS.abiflags-s.patch
Description: 0003-Setting-of-status-register-based-on-.MIPS.abiflags-s.patch

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]