This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch, Newlib-nano]Improve printf to support non nul-terminated string



> -----Original Message-----
> From: Bin.Cheng [mailto:amker.cheng@gmail.com]
> Sent: Thursday, November 06, 2014 1:06 PM
> To: Joey Ye
> Cc: Terry Guo; Bin Cheng; newlib@sourceware.org
> Subject: Re: [Patch, Newlib-nano]Improve printf to support non nul-
> terminated string
> 
> On Thu, Nov 6, 2014 at 12:10 PM, Joey Ye <joey.ye.cc@gmail.com> wrote:
> > Now there is no point to keep #if 0. Please remove it.
> 
> 
> Yes, I think both the commentary and #if 0 below are not needed any more.
> 
>       /* Below code is kept for reading.  The check is redundant because
>      pdata->prec will be set to pdata->size if it is -1 previously.  */
#if 0
>       if (pdata->prec > pdata->size)
> #endif
> 
> Thanks,
> bin

Thanks. Here is updated patch. Is this one OK?

BR,
Terry

Attachment: nano-non-nul-terminated-v5.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]