RE: [PATCH newlib]Bring back wchar io files for --disable-newlib-wide-orient option

["bin.cheng" <bin dot cheng at arm dot com>]

> -----Original Message-----
> From: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org] On Behalf Of freddie_chopin
> Sent: Monday, August 12, 2013 3:47 PM
> To: newlib@sourceware.org; Bin Cheng
> Subject: Re: [PATCH newlib]Bring back wchar io files for --disable-newlib-wide-orient option
>
> W dniu 2013-08-12 03:55:07 uÅytkownik bin.cheng <bin.cheng@arm.com> napisaÅ:
> > Hi,
> > 
> > When I introduced configuration option "--disable-newlib-wide-orient", 
> > I removed the build of wchar's io files like getwc/putwc/fgetwc/fputwc, etc..
> > This is inappropriate because: A) wchar's IO is not same thing with 
> > wide orientation, it should work even if wide orientation is disabled 
> > (though these io function would not set file orientation any more).  
> > B) C++ iostream depends on wchar's IO functions even it's not used 
> > explicitly by user program.
> > 
> > This patch brings these wchar's IO files back.  I built newlib 
> > with/without the option and ran gcc regression test with the patch.  Is it OK?
> > 
> > Thanks.
> > bin
> > 
> > 2013-08-12  Bin Cheng  <bin.cheng@arm.com>
> > 
> > 	* libc/configure.in (--enable-newlib-wchar-orient): Remove.
> > 	* libc/configure: Regenerated.
> > 	* libc/stdio/Makefile.am (NEWLIB_WIDE_ORIENT): Remove.
> > 	* libc/stdio/Makefile.in: Regenerated.
> > 
>
> Does it mean that the option will be removed completely and no alternative will be introduced? Maybe it would be possible to introduce empty wchar stubs?
>
Look only libc part is removed.  The only difference is wchar IO functions will be built now if "--disable-newlib-wide-orient" is specified.

Thanks.
bin