This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Move _wrapup_reent() to new file
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: newlib at sourceware dot org
- Date: Thu, 25 Apr 2013 17:58:28 +0200
- Subject: Re: [PATCH] Move _wrapup_reent() to new file
- References: <1366881156-9673-1-git-send-email-sebastian dot huber at embedded-brains dot de> <5179424D dot 8060107 at oarcorp dot com> <20130425152744 dot GG2875 at calimero dot vinschen dot de> <51794C88 dot 3070401 at oarcorp dot com>
- Reply-to: newlib at sourceware dot org
On Apr 25 10:32, Joel Sherrill wrote:
> On 4/25/2013 10:27 AM, Corinna Vinschen wrote:
> >On Apr 25 09:48, Joel Sherrill wrote:
> >>I am OK with this. I was looking to see if the new file
> >>should have some comment block at the top but
> >>there is no notice in reent.c and the method isn't
> >>public. So that doesn't leave much.
> >>
> >>Corinna?
> >Given that _wrapup_reent seems to be unused, I wonder if we shouldn't
> >rather make an experiment: Just #if 0 it. If somebody complains
> >we can easily revert that. If not...
> How long would you like to leave it disabled before killing it?
>
> That's my only concern. Code gets disabled and never removed. I
> can set a calendar alarm to remind me about this. But after how long?
If it's #if 0'd it doesn't hurt at all, even if we keep it for a long
time. If you add a comment, archaeologists will be able to find the
reason and still remove it any time. Apart from that, next newlib
release is in December. That's when we can remove it.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat