Re: Use of -fshort-enums for certain files

[Michael Bruck <bruck dot michael at gmail dot com>]

The flag is probably not needed. When it was introduced the file used
some large lookup tables that benefited from this:

http://sourceware.org/cgi-bin/cvsweb.cgi/src/newlib/libc/stdio/vfprintf.c?rev=1.16&content-type=text/x-cvsweb-markup&cvsroot=src

Modifying the ABI on a file-by-file basis in a library seems to be
asking for trouble and the original rationale for using the flag is
gone. Risk with no reward, I recommend deleting the flags entirely.

Michael


On Tue, Apr 2, 2013 at 1:39 PM, Corinna Vinschen <vinschen@redhat.com> wrote:
> On Mar 31 00:53, Michael Bruck wrote:
>> libc/stdio/Makefile.in uses "-fshort-enums" for several files.
>>
>> This causes problems with ARM targets that have this option disabled
>> by default. On ARM the enum format is stored as flag in the elf file
>> and the linker notes the discrepancy. So even if this hard-coded flag
>> is purely internal in these library files and affects no external
>> interfaces it still causes errors when linked with other objects.
>
> Patches to make usage of this flag a configure option are welcome.
>
>
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat