This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] string.h/strings.h


On 08/19/2011 05:16 PM, Corinna Vinschen wrote:
On Aug 19 16:10, Ralf Corsepius wrote:
On 08/19/2011 03:59 PM, Eric Blake wrote:
On 08/19/2011 07:52 AM, Ralf Corsepius wrote:
Hi,

I would like to apply the patch below.
[...]
* libc/string/bcmp.c: Include<strings.h>  for "memcmp".

Wrong wording - this file needs two headers:<strings.h> for (obsolete) bcmp (missing, which meant we were implementing the function without pulling in its declaration), but<string.h> for memcmp (already present).
I knew, I would mix them up somewhere ;)

Next iteration of the patch attached below.

Ralf


	* libc/string/bcmp.c: Include<strings.h>  for "bcmp".
	* libc/string/bcopy.c: Include<strings.h>  for "bcopy".
	* libc/string/strcasestr.c: Include<strings.h>  for "strncasecmp".
	* libc/time/strptime.c: Include<strings.h>  for "strncasecmp".

Please apply.

Done.


Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]