Re: fix fputc and friends on read-only streams

[Eric Blake <eblake at redhat dot com>]

On 06/13/2011 04:15 PM, Jeff Johnston wrote:
> I'm fine with the change, but you should probably remove the redundant
> errno and error flag setting in wbuf.c and fvwrite.c.
> 
> In addition, it would be nice to document in the local.h comment that
> cantwrite macro will set errno and error flag.  This will prevent future
> code from setting errno and the error flag themselves or thinking it is
> just a test.

Done with those changes (cantwrite now normally sets errno to EBADF, but
can also set errno to ENOMEM if allocating/resizing a buffer fails, so
this is actually a good change so that wbuf.c does not blindly set errno
to EBADF and lose the real error in that case).

>> ---
>>   newlib/ChangeLog           |    4 ++++
>>   newlib/libc/stdio/wsetup.c |    6 +++++-
>>   2 files changed, 9 insertions(+), 1 deletions(-)

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature