This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [RFA] Add missing fields to struct lc_time_T
On Feb 18 11:53, Howland Craig D (Craig) wrote:
> Corinna:
> It would be nice if the comments being added to timelocal.h did what
> the existing ones do by including the structure member being
> initialized.
> Following is a suggestion enhancing your patch. (I did check against
> POSIX, and added members look proper.)
> Craig
>
> Index: timelocal.c
> ===================================================================
> RCS file: /cvs/src/src/newlib/libc/locale/timelocal.c,v
> retrieving revision 1.3
> diff -p -u -r1.3 timelocal.c
> --- timelocal.c 9 Feb 2010 08:58:38 -0000 1.3
> +++ timelocal.c 18 Feb 2010 16:49:43 -0000
> @@ -92,7 +92,29 @@ static const struct lc_time_T _C_time_lo
> /* ampm_fmt
> * To determine 12-hour clock format time (empty, if N/A)
> */
> - "%I:%M:%S %p"
> + "%I:%M:%S %p",
> +
> + /* era
> + * This and the following entries are used if the alternative
> + * date format is specified in strftime
> + */
> + "",
> +
> + /* era_d_fmt
> + * Era date format used with the %Ex */
> + "",
> +
> + /* era_d_t_fmt
> + * Era date/time format (%Ec) */
> + "",
> +
> + /* era_t_fmt
> + * Era time format (%EX) */
> + "",
> +
> + /* alt_digits
> + * Alternate digits used if %O format prefix is specified */
> + ""
> };
>
> struct lc_time_T *
>
Sure, fine with me.
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat