This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PTACH] strchr broken on SPU with non 16byte aligned argument
Kazunori Asayama <asayama@sm.sony.co.jp> wrote:
> Joel Sherrill <joel.sherrill@oarcorp.com> wrote:
> > Any ideas whether other spu/str* code has similar pointer math which
> > might be suspect?
>
> Anyway, we should have and run tests against both of aligned and
> unaligned inputs. If so, we would be able to avoid this bug.
>
> And I think that such tests are useful not only for SPU specific
> implementations, but also for generic ones
> (i.e. newlib/libc/string/*), because some of them also do 'special
> processing' against unaligned inputs.
Hmm, there is such a test in testsuite/newlib.string/tstring.c. That
is, that test had never been run on SPU. Indeed, tstring.c could not
be run by another reason (stack overflow)...
--
(ASAYAMA Kazunori
(asayama@sm.sony.co.jp))
t