This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add bfin target

From: Ralf Corsepius <ralf dot corsepius at rtems dot org>
To: Jeff Johnston <jjohnstn at redhat dot com>
Cc: Alain Schaefer <alani at easc dot ch>, newlib at sources dot redhat dot com
Date: Thu, 14 Sep 2006 07:03:21 +0200
Subject: Re: [PATCH] add bfin target
References: <cc8c5c9b0609131121q29147f70p1d5a1bb0f435e59c@mail.gmail.com> <45088410.7020406@redhat.com>

On Wed, 2006-09-13 at 18:20 -0400, Jeff Johnston wrote:
> Hi Alain,
> 
>    A couple of points/comments.
> 
>    1. You need to define the setjmp buffer in libc/include/machine/setjmp.h
> 
>    2. Your Makefile.am and configure.in should be based on the
>       ones in libc/machine/fr30 to comply with the latest
>       autotools support
> 
>    3. Minor nit: remove reference to arm in your configure.in
> 
>    4. What do the #defines at the top of setjmp.S do?
> 
>    5. Are the defaults in libc/include/sys/config.h ok for you?

6. setjmp.S lacks an appropriate Copyright/License notice.

Ralf

References:
- [PATCH] add bfin target
  - From: Alain Schaefer
- Re: [PATCH] add bfin target
  - From: Jeff Johnston

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]