Re: Linux fixes [PATCH]

[Jeff Johnston <jjohnstn at redhat dot com>]

Shaun Jackman wrote:
> 2005/10/26, Shaun Jackman <sjackman@gmail.com>:
>
> > 2005/10/26, Jeff Johnston <jjohnstn@redhat.com>:
> >
> > > Regarding dl-load.c: I am able to build this
> > > on my FC-4 system.  dl-load.c includes ldsodefs.h which then includes
> > > dlfcn.h which is found in libc/sys/linux/include and defines
> > > __RTLD_DLOPEN.  Why aren't you picking this up in your build?
> > >
> > > -- Jeff J.
> >
> > It appears as though it is supposed to be that dl-load.c includes
> > ldsodefs.h, which includes linux/include/dlfcn.h, which includes
> > linux/dl/dlfcn.h, which includes linux/sys/dlfcn.h. Unfortunately, the
> > #include <dlfcn.h> statement in  ldsodefs.h is pulling in
> > linux/dl/dlfcn.h instead of linux/include/dlfcn.h. This is also a
> > problem because the installed include/dlfcn.h includes <dl/dlfcn.h>,
> > which is not installed.
> >
> > If I change the #include <dlfcn.h> in ldsodefs.h to #include
> > <include/dlfcn.h> -- a hack which I certainly don't recommend -- it
> > works.
> >
> > Cheers,
> > Shaun
>
>
> This dlfcn.h (__RTLD_DLOPEN) issue persists for me. Any thoughts on
> the matter? Is this bug truly specific to my build system? After
> inspecting the bug, it looks as though it should affect all systems.
>
> Cheers,
> Shaun

After looking at the dlfcn.h that gets installed, that just isn't right. 
 It appears that the dlfcn.h in linux/dl is the one we actually want to 
install (i.e. per the standard) and the one in linux/include is really 
the one we want local to the dl directory when building.  This is what 
your hack is doing.  I have just tried switching the headers around and 
fixing up ldsodefs.h to use the local header file.  The build from 
scratch worked fine.  I'll post the change shortly.

-- Jeff J.

-- Jeff J.