This is the mail archive of the
newlib@sources.redhat.com
mailing list for the newlib project.
patch: powerpc vfprintf fix
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: jjohnstn at redhat dot com, newlib at sources dot redhat dot com
- Date: Tue, 18 Jan 2005 10:40:25 -0400
- Subject: patch: powerpc vfprintf fix
Hi Jeff. Hi folks.
[Ok, this time with the right address]
It looks like the PPC vfprintf is suffering from some bit-rot. The
patch below fixes printf's of floating point numbers.
The function vfprintf was passing NULL to _vfprintf_r, which later was
causing a dereference to a NULL pointer.
Is this ok?
* libc/machine/powerpc/vfprintf.c: Use _REENT when calling
_VFPRINTF_R.
Index: libc/machine/powerpc/vfprintf.c
===================================================================
RCS file: /cvs/src/src/newlib/libc/machine/powerpc/vfprintf.c,v
retrieving revision 1.9
diff -c -p -r1.9 vfprintf.c
*** libc/machine/powerpc/vfprintf.c 26 May 2004 00:19:14 -0000 1.9
--- libc/machine/powerpc/vfprintf.c 18 Jan 2005 14:32:43 -0000
*************** _DEFUN (VFPRINTF, (fp, fmt0, ap),
*** 322,329 ****
_CONST char *fmt0 _AND
va_list ap)
{
! CHECK_INIT (fp);
! return _VFPRINTF_R (fp->_data, fp, fmt0, ap);
}
int
--- 322,328 ----
_CONST char *fmt0 _AND
va_list ap)
{
! return _VFPRINTF_R (_REENT, fp, fmt0, ap);
}
int