This is the mail archive of the
newlib@sources.redhat.com
mailing list for the newlib project.
Re: patch: various missing includes
- To: Werner Almesberger <almesber at lrc dot epfl dot ch>
- Subject: Re: patch: various missing includes
- From: "J. Johnston" <jjohnstn at cygnus dot com>
- Date: Thu, 24 Aug 2000 14:56:54 -0400
- CC: newlib at sources dot redhat dot com
- Organization: Red Hat Inc.
- References: <200008231403.QAA26157@lrcsun15.epfl.ch>
Werner Almesberger wrote:
>
> This patch adds lots of missing includes. Most of them are straight from
> POSIX 1003.1. Exceptions: all the reent.h things, strdup (assumption: from
> string.h) and gettimeofday (assumption: from sys/time.h).
>
> 85 warnings left ...
>
> - Werner
>
Thanks Werner, the patch has been applied. I changed the comment in abort.c slightly to
mention that write was only optionally required as an OS routine and to remove
raise as it is not categorized as one of the underlying OS routines.
-- Jeff Johnston (Red Hat Inc).
> ---------------------------------- ChangeLog ----------------------------------
>
> 2000-08-23 Werner Almesberger <Werner.Almesberger@epfl.ch>
> * libc/stdlib/abort.c: changed description: uses "raise" instead of
> "getpid" and "kill"; added: uses "write" and "_exit"
> * libc/stdlib/abort.c: included unistd.h for "_exit" prototype
> * libc/stdlib/system.c: included unistd.h for "execve" prototype,
> reent.h for "_fork_r" and "_wait_r" prototypes
> * libc/stdlib/system.c (do_system): changed extern char *environ[];
> to POSIX-friendly extern char **environ;
> * libc/stdlib/wctomb_r.c: included string.h for "strlen" and "strcmp"
> prototypes
> * libc/stdlib/remove.c: included reent.h for "_unlink_r" prototype
> * libc/reent/execr.c: included sys/wait.h for "wait" prototype
> * libc/reent/fstatr.c: included sys/stat.h for "fstat" prototype
> * libc/reent/openr.c: included fcntl.h for "open" prototype
> * libc/reent/signalr.c: included signal.h for "kill" prototype,
> unistd.h for "getpid" prototype
> * libc/reent/statr.c: included sys/stat.h for "stat" prototype
> * libc/reent/timer.c: included sys/time.h for "gettimeofday" prototype
> * libc/unix/getut.c (utmpname): removed local, incorrect "strdup"
> prototype
> * libc/unix/getut.c: included stdlib.h for "abort", string.h for
> "strdup" and "strncmp" prototypes
> * libc/unix/getlogin.c: included string.h for "strncmp", "memset", and
> "strncpy", unistd.h for "read" and "close" prototypes
> * libc/posix/execvp.c: included string.h for "strchr", "strlen", and
> "strcat" prototypes
>