This is the mail archive of the newlib-cvs@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[newlib-cygwin] Remove float compare option from sincosf


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=81dc535bb9e0196203e706caa533713306b4fc2c

commit 81dc535bb9e0196203e706caa533713306b4fc2c
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Tue Jul 10 17:14:32 2018 +0100

    Remove float compare option from sincosf
    
    PREFER_FLOAT_COMPARISON setting was not correct as it could raise
    spurious exceptions.  Fixing it is easy: just use ISLESS(x, y) instead
    of abstop12(x) < abstop12(y) with appropriate non-signaling definition
    for ISLESS.  However it seems this setting is not very useful (there is
    only minor performance difference on various architectures), so remove
    this option for now.

Diff:
---
 newlib/libm/common/sincosf.h | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/newlib/libm/common/sincosf.h b/newlib/libm/common/sincosf.h
index 27f24ff..3cac8e8 100644
--- a/newlib/libm/common/sincosf.h
+++ b/newlib/libm/common/sincosf.h
@@ -43,21 +43,12 @@ extern const sincos_t __sincosf_table[2] HIDDEN;
 
 extern const uint32_t __inv_pio4[] HIDDEN;
 
-/* abstop12 assumes floating point reinterpret is fast by default.
-   If floating point comparisons are faster, define PREFER_FLOAT_COMPARISON.  */
-#if PREFER_FLOAT_COMPARISON
-static inline float
-abstop12 (float x)
-{
-  return fabsf (x);
-}
-#else
+/* Top 12 bits of the float representation with the sign bit cleared.  */
 static inline uint32_t
 abstop12 (float x)
 {
   return (asuint (x) >> 20) & 0x7ff;
 }
-#endif
 
 /* Compute the sine and cosine of inputs X and X2 (X squared), using the
    polynomial P and store the results in SINP and COSP.  N is the quadrant,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]