Re: [PATCH] Fix xmlout option

[Omair Majid <omajid at redhat dot com>]

Hi Mark,

Mark Wielaard wrote:
> Thanks. It took me some time to understand how this was supposed to work
> with the ping-pong between Harness and RunnerProcess. I am afraid you
> might be the first one in a long time that has worked with the xml
> output. So don't be surprised if you find more bugs. Sorry about that.

I am just glad there is an xmlout option at all!

> I think you should explicitly check that args.length still has another
> element like the other checks before this one. The help message implies
> that the file name is optional, but it really isn't since RunnerProcess
> depends on it. Could you make that change and update the help message?

Good catch. Fixed patch attached. I am not sure how the help message 
indicates that the file name is optional. 'filename' in '-file 
[filename]' is required and so is 'millis' in '-timeout [millis]'.

Cheers,
Omair


--- Harness.java.orig	2009-02-12 11:30:11.000000000 -0500
+++ Harness.java	2009-02-13 09:58:05.000000000 -0500
@@ -338,6 +338,14 @@
                     "after '-timeout'.  Exit");
             runner_timeout = Long.parseLong(args[i]);
           }
+        else if (args[i].equals("-xmlout"))
+          {
+            // User wants output in an xml file
+            if (++i >= args.length)
+              throw new RuntimeException ("No file " +
+                    "given after '-xmlout'.  Exit");
+            // the filename is used directly from args
+          }
         else if (args[i].charAt(0) == '-')
           {
             // One of the ignored options (handled by RunnerProcess)