This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
FYI: fix DefaultComboBoxModel.setSelectedItem test
- From: Thomas Fitzsimmons <fitzsim at redhat dot com>
- To: mauve-patches at sources dot redhat dot com
- Date: Fri, 13 Oct 2006 01:25:28 -0400
- Subject: FYI: fix DefaultComboBoxModel.setSelectedItem test
Hi,
I committed this fix. When setSelectedItem is passed an object that is
not in the list, it simply returns without doing anything.
Tom
2006-10-13 Thomas Fitzsimmons <fitzsim@redhat.com>
* gnu/testlet/javax/swing/DefaultComboBoxModel/setSelectedItem.java
(test): Correct "item not in the list" case.
Index: gnu/testlet/javax/swing/DefaultComboBoxModel/setSelectedItem.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/DefaultComboBoxModel/setSelectedItem.java,v
retrieving revision 1.2
diff -u -r1.2 setSelectedItem.java
--- gnu/testlet/javax/swing/DefaultComboBoxModel/setSelectedItem.java 11 Oct 2005 20:32:47 -0000 1.2
+++ gnu/testlet/javax/swing/DefaultComboBoxModel/setSelectedItem.java 13 Oct 2006 05:21:08 -0000
@@ -87,16 +87,13 @@
// now set the selected item to something not in the list...
m.setSelectedItem("Z");
- harness.check(m.getSelectedItem(), "Z");
+ // confirm that setSelectedItem simply returned without doing
+ // anything...
+ harness.check(m.getSelectedItem(), null);
harness.check(m.getSize(), 3);
harness.check(m.getIndexOf("Z"), -1);
- harness.check(events.size(), 1);
- event = (ListDataEvent) events.get(0);
- harness.check(event.getType(), ListDataEvent.CONTENTS_CHANGED);
- harness.check(event.getIndex0(), -1);
- harness.check(event.getIndex1(), -1);
- events.clear();
-
+ harness.check(events.size(), 0);
+
// now set the selected item to the same value - no event should be
// generated...
m.setSelectedItem("Z");