This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

FYI: Calendar.getInstance() - new checks


This patch (committed) adds some checks for the Calendar.getInstance() methods:

2006-10-06 David Gilbert <david.gilbert@object-refinery.com>

   * gnu/testlet/java/util/Calendar/getInstance.java:
   (testMethod1): Added check for new instance,
   (testMethod2): Likewise,
   (testMethod3): Likewise,
   (testMethod4): Likewise.

Regards,

Dave
Index: gnu/testlet/java/util/Calendar/getInstance.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/util/Calendar/getInstance.java,v
retrieving revision 1.1
diff -u -r1.1 getInstance.java
--- gnu/testlet/java/util/Calendar/getInstance.java	17 Aug 2006 12:05:11 -0000	1.1
+++ gnu/testlet/java/util/Calendar/getInstance.java	6 Oct 2006 08:19:49 -0000
@@ -48,6 +48,10 @@
     harness.checkPoint("()");
     Calendar c = Calendar.getInstance();
     harness.check(c.getTimeZone(), java.util.TimeZone.getDefault());
+    
+    // check that the method returns a new instance each time
+    Calendar c2 = Calendar.getInstance();
+    harness.check(c != c2);
   }
   
   public void testMethod2(TestHarness harness) 
@@ -56,6 +60,10 @@
     Calendar c = Calendar.getInstance(java.util.TimeZone.getTimeZone("GMT"));
     harness.check(c.getTimeZone(), java.util.TimeZone.getTimeZone("GMT"));
     
+    // check that the method returns a new instance each time
+    Calendar c2 = Calendar.getInstance(java.util.TimeZone.getTimeZone("GMT"));
+    harness.check(c != c2);
+
     // try null
     boolean pass = false;
     try 
@@ -72,6 +80,9 @@
   public void testMethod3(TestHarness harness) 
   {
     harness.checkPoint("(Locale)");       
+    Calendar c = Calendar.getInstance(Locale.UK);
+    Calendar c2 = Calendar.getInstance(Locale.UK);
+    harness.check(c != c2);
         
     // try null
     boolean pass = false;
@@ -89,6 +100,11 @@
   public void testMethod4(TestHarness harness) 
   {
     harness.checkPoint("(TimeZone, Locale)");   
+    Calendar c = Calendar.getInstance(java.util.TimeZone.getTimeZone("GMT"), 
+            Locale.UK);
+    Calendar c2 = Calendar.getInstance(java.util.TimeZone.getTimeZone("GMT"), 
+            Locale.UK);
+    harness.check(c != c2);
 
     // try null TimeZone
     boolean pass = false;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]