This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
FYI: remove trailing chars from FAIL lines
- From: Mark Wielaard <mark at klomp dot org>
- To: mauve-patches at sources dot redhat dot com
- Date: Wed, 26 Jul 2006 01:09:23 +0200
- Subject: FYI: remove trailing chars from FAIL lines
Hi,
To make it easier for a regression tester to see changes between PASS
and FAIL lines they have to be as similar as possible. This patch
removes some trailing chars in a couple of places. If everything is
setup right then every PASS and FAIL line should only have ": " and the
(short) test class name on them now.
2006-07-25 Mark Wielaard <mark@klomp.org>
* Harness.java: Remove all trailing chars from FAIL output.
* RunnerProcess.java: Likewise.
Committed,
Mark
Index: Harness.java
===================================================================
RCS file: /cvs/mauve/mauve/Harness.java,v
retrieving revision 1.20
diff -u -r1.20 Harness.java
--- Harness.java 16 Jul 2006 12:46:25 -0000 1.20
+++ Harness.java 25 Jul 2006 23:05:28 -0000
@@ -1336,7 +1336,7 @@
+ "\n FAIL: compilation errors:");
else
super.println("FAIL: " + shortName
- + ": compilation errors:");
+ + "\n compilation errors:");
// Increment and set the relevant variables.
numCompileFailsInFolder = 1;
Index: RunnerProcess.java
===================================================================
RCS file: /cvs/mauve/mauve/RunnerProcess.java,v
retrieving revision 1.11
diff -u -r1.11 RunnerProcess.java
--- RunnerProcess.java 29 Jun 2006 17:19:11 -0000 1.11
+++ RunnerProcess.java 25 Jul 2006 23:05:28 -0000
@@ -229,7 +229,7 @@
shortName);
else
System.out.println("FAIL: " + stripPrefix(testname)
- + ": failed to load");
+ + "\n failed to load");
System.out.println("RunnerProcess:fail-0");
}
}
@@ -311,7 +311,8 @@
if (!verbose)
- System.out.println ("FAIL: " + stripPrefix(name) + ": exception when loading:");
+ System.out.println ("FAIL: " + stripPrefix(name)
+ + "\n exception when loading:");
else
{
System.out.println ("TEST: "+stripPrefix(name));
@@ -343,7 +344,7 @@
String r = getStackTraceString(ex, " ");
if (failures == 0 && !verbose)
- System.out.println ("FAIL: " + stripPrefix(name) + ":");
+ System.out.println ("FAIL: " + stripPrefix(name));
System.out.println(d);
removeSecurityManager();
currentResult.addException(ex, d, r);
@@ -657,7 +658,7 @@
// If the failure wasn't expected, we need to print it to the
// screen.
if (failures == 0 && !verbose)
- System.out.println ("FAIL: " + stripPrefix(description) + ":");
+ System.out.println ("FAIL: " + stripPrefix(description));
if (verbose)
System.out.print(" FAIL:");
System.out.print(desc + " -- ");