This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
Re: Patch: New Lightweight tests
On Wed, 2006-02-22 at 10:29 +0000, David Gilbert wrote:
> Hi Lillian,
>
> Lillian Angel wrote:
>
> >
> >Index: gnu/testlet/java/awt/Container/LightweightContainer.java
> >===================================================================
> >
> >
> >
>
> >+ harness.checkRectangleOuterColors(r, bounds2, Color.red, true);
> >+ harness.checkRectangleCornerColors(r, bounds2, Color.red, false);
> >+
> >+ r.delay(3000);
> >+ }
> >
> >
> Do you know what the delay is for? Is there some other way to write the
> test so that the delay isn't required? It's just that it would be nice
> if the Mauve test run doesn't take longer than it has to - otherwise
> hackers will stop running it.
The three second delays are to help the human tester see the result,
though we should probably enable or disable them based on if Mauve is
running in headless mode. The new AWT utility class that we add could
check the SHOW_GUI_TESTS environment variable and cache its value.
We require:
+ r.waitForIdle();
+ r.delay(300);
after showing a frame, before checking pixels in it so that GTK has had
time to draw it. I think this is documented in one of the other AWT
tests.
Tom