This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: New Test File.getParent


Mark Wielaard wrote:

Hi Wolfgang,



...

Why do you have the following check at the start of the test?



SimpleTestHarness testharness = null;
try {
testharness = (SimpleTestHarness) harness;
} catch (ClassCastException cce)
{
harness.fail ("Harness not an instance of SimpleTestHarness");
return;
}



I couldn't find anything in your test that needs anything not in the TestHarness interface.

Cheers,

Mark


Yes, please write tests to the TestHarness interface only. This matters, for example, in the Mauve test report that I run:

http://www.object-refinery.com/classpath/mauve/report/

...because it is generated using gnu.testlet.runner.Mauve, and not SimpleTestHarness. So if your test class checks for SimpleTestHarness, it will have to be excluded from the Mauve report, which would be a shame.

New tests in Mauve are always appreciated, so thanks for your efforts!

Regards,

Dave Gilbert


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]