This is the mail archive of the
mauve-patches@sources.redhat.com
mailing list for the Mauve project.
Fix to some calendar tests (Locale issues)
- From: Sven de Marothy <sven at physto dot se>
- To: mauve-patches at sources dot redhat dot com
- Date: Mon, 07 Mar 2005 01:27:16 +0100
- Subject: Fix to some calendar tests (Locale issues)
Here's a patch for gnu/testlet/java/util/Calendar/set.java,
I noticed I was getting several false negatives due to my locale
settings.
Several of the tests are locale-dependent, such as the ones which test a
pattern including DAY_OF_WEEK, without setting DAY_OF_WEEK, in which
case it defaults to the first day of the week, which is
locale-dependent.
This fix explicitly sets the locale on the created Calendar objects.
(Although currently, the getFirstDayOfWeek() method is wrong in
Classpath CVS, but it's fixed in my tree.)
So just a heads-up to everyone too: Be careful about locale
dependencies, they can sneak up on you!
/Sven
Index: gnu/testlet/java/util/Calendar/set.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/util/Calendar/set.java,v
retrieving revision 1.6
diff -u -r1.6 set.java
--- gnu/testlet/java/util/Calendar/set.java 22 Nov 2004 22:00:15 -0000 1.6
+++ gnu/testlet/java/util/Calendar/set.java 7 Mar 2005 00:19:10 -0000
@@ -45,7 +45,7 @@
private void testSimple(TestHarness harness)
{
harness.checkPoint("Simple tests");
- Calendar c = Calendar.getInstance();
+ Calendar c = Calendar.getInstance(Locale.FRANCE);
c.setTimeZone(TimeZone.getTimeZone("GMT"));
c.clear();
@@ -118,7 +118,7 @@
public void test_DAY_OF_MONTH(TestHarness harness)
{
harness.checkPoint("setting DAY_OF_MONTH etc shouldn't effect other fields");
- Calendar c = Calendar.getInstance();
+ Calendar c = Calendar.getInstance(Locale.FRANCE);
SimpleDateFormat df = new SimpleDateFormat("EEEEEEEEEEEEE, yyyy-MM-dd [DDD] HH:mm:ss.SSSS", Locale.US);
c.set(2004, 9, 1, 12, 0, 0);
c.set(Calendar.MILLISECOND, 0);
@@ -139,7 +139,7 @@
{
harness.checkPoint("setting only some fields");
- Calendar c = Calendar.getInstance();
+ Calendar c = Calendar.getInstance(Locale.FRANCE);
c.setTimeZone(TimeZone.getTimeZone("GMT"));
c.clear();
@@ -176,7 +176,7 @@
private void testLenience(TestHarness harness)
{
harness.checkPoint("test the setLenient() functionality");
- Calendar c = Calendar.getInstance();
+ Calendar c = Calendar.getInstance(Locale.FRANCE);
c.setLenient(false);
c.set(Calendar.MONTH, 42);
boolean b = false;
@@ -194,7 +194,7 @@
private void testConflictingFields(TestHarness harness)
{
harness.checkPoint("test setting conflicting values of different fields");
- Calendar c = Calendar.getInstance();
+ Calendar c = Calendar.getInstance(Locale.FRANCE);
c.setTimeZone(TimeZone.getTimeZone("GMT"));
c.clear();
@@ -249,7 +249,7 @@
private void testNormalization(TestHarness harness)
{
harness.checkPoint("Normalization");
- Calendar c = Calendar.getInstance();
+ Calendar c = Calendar.getInstance(Locale.FRANCE);
c.setTimeZone(TimeZone.getTimeZone("GMT"));
// negative HOUR_OF_DAY