Re: java.awt.geom.AffineTransform

[Mark Wielaard <mark at klomp dot org>]

Hi Dave,

On Sun, 2004-08-15 at 22:31, David Gilbert wrote:
> On Sun, 2004-08-15 at 12:01, Mark Wielaard wrote:
> Sorry about that, I was working too late - I attached a test
> (transform.java) that I hadn't actually run.  I've fixed the bugs and
> attached a new version.

Thanks I get the same results as you now:
FAIL: gnu.testlet.java.awt.geom.AffineTransform.createTransformedShape (number 10)
FAIL: gnu.testlet.java.awt.geom.AffineTransform.inverseTransform (number 4)
FAIL: gnu.testlet.java.awt.geom.AffineTransform.inverseTransform (number 6)
FAIL: gnu.testlet.java.awt.geom.AffineTransform.inverseTransform (number 8)
FAIL: gnu.testlet.java.awt.geom.AffineTransform.inverseTransform (number 12)
FAIL: gnu.testlet.java.awt.geom.AffineTransform.inverseTransform (number 14)
6 of 257 tests failed

> > > The first error is some unusual behaviour in Sun's implementation where
> > > the createTransformedShape(Shape) method will accept a null argument.
> > > Classpath throws a NullPointerException.  I searched Sun's bug parade
> > > and it is in there as report 4190350, status "will not fix".
> > 
> > So it is a bug they refuse to fix.
> > Shouldn't the test then fail on their implementation?
> 
> The spec is incomplete so I guess there is no right answer.  Feel free
> to reverse the check if you want.

No, the way you do it is correct.
Someone investigated it for some other implementation and decided that
the current behavior is the expected one. Even though I don't completely
agree with the reasoning it doesn't make sense to deliberately do
something different.

Checked in all the new tests as follows:

2004-08-27  David Gilbert  <david.gilbert@object-refinery.com>

        * gnu/testlet/java/awt/geom/AffineTransform/clone.java: New test.
        * gnu/testlet/java/awt/geom/AffineTransform/concatenate.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/constants.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/constructors.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/createInverse.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/createTransformedShape.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/deltaTransform.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/equals.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/getDeterminant.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/getMatrix.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/getRotateInstance.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/getScaleInstance.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/getShearInstance.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/getTranslateInstance.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/inverseTransform.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/isIdentity.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/preConcatenate.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/setTransform.java:
        Likewise.
        * gnu/testlet/java/awt/geom/AffineTransform/transform.java:
        Likewise.

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part