This is the mail archive of the
mauve-discuss@sourceware.org
mailing list for the Mauve project.
Patch: Float/DoubleBuffer compareTo
- From: Anthony Green <green at redhat dot com>
- To: Mauve Discuss <mauve-discuss at sources dot redhat dot com>
- Date: Mon, 05 Dec 2005 20:35:05 -0800
- Subject: Patch: Float/DoubleBuffer compareTo
These tests point out a bug in GNU Classpath. Float and Double buffers
built from identical arrays containing NaN values should still compare
as equal. I'm checking this in.
Float/DoubleBuffer.compareTo need special checks for this case.
Something like (a != a) && (b != b).
2005-12-05 Anthony Green <green@redhat.com>
* gnu/testlet/java/nio/DoubleBuffer/compareTo.java: New test.
* gnu/testlet/java/nio/FloatBuffer/compareTo.java: New test.
Index: gnu/testlet/java/nio/DoubleBuffer/compareTo.java
===================================================================
RCS file: gnu/testlet/java/nio/DoubleBuffer/compareTo.java
diff -N gnu/testlet/java/nio/DoubleBuffer/compareTo.java
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/java/nio/DoubleBuffer/compareTo.java 6 Dec 2005 04:28:29 -0000
@@ -0,0 +1,43 @@
+// Tags: JDK1.4
+
+// Copyright (C) 2005 Red Hat, Inc.
+
+// This file is part of Mauve.
+
+// Mauve is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2, or (at your option)
+// any later version.
+
+// Mauve is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Mauve; see the file COPYING. If not, write to
+// the Free Software Foundation, 59 Temple Place - Suite 330,
+// Boston, MA 02111-1307, USA.
+
+
+package gnu.testlet.java.nio.DoubleBuffer;
+
+import gnu.testlet.Testlet;
+import gnu.testlet.TestHarness;
+
+import java.nio.*;
+
+public class compareTo implements Testlet
+{
+ public void test(TestHarness h)
+ {
+ double darray[] = new double[1];
+ darray[0] = Double.NaN;
+
+ DoubleBuffer fb1 = DoubleBuffer.wrap(darray);
+ DoubleBuffer fb2 = DoubleBuffer.wrap(darray);
+
+ h.check(fb1.compareTo(fb2), 0, "double buffer compare with NaN entry");
+ }
+}
+
Index: gnu/testlet/java/nio/FloatBuffer/compareTo.java
===================================================================
RCS file: gnu/testlet/java/nio/FloatBuffer/compareTo.java
diff -N gnu/testlet/java/nio/FloatBuffer/compareTo.java
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/java/nio/FloatBuffer/compareTo.java 6 Dec 2005 04:28:29 -0000
@@ -0,0 +1,43 @@
+// Tags: JDK1.4
+
+// Copyright (C) 2005 Red Hat, Inc.
+
+// This file is part of Mauve.
+
+// Mauve is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2, or (at your option)
+// any later version.
+
+// Mauve is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Mauve; see the file COPYING. If not, write to
+// the Free Software Foundation, 59 Temple Place - Suite 330,
+// Boston, MA 02111-1307, USA.
+
+
+package gnu.testlet.java.nio.FloatBuffer;
+
+import gnu.testlet.Testlet;
+import gnu.testlet.TestHarness;
+
+import java.nio.*;
+
+public class compareTo implements Testlet
+{
+ public void test(TestHarness h)
+ {
+ float farray[] = new float[1];
+ farray[0] = Float.NaN;
+
+ FloatBuffer fb1 = FloatBuffer.wrap(farray);
+ FloatBuffer fb2 = FloatBuffer.wrap(farray);
+
+ h.check(fb1.compareTo(fb2), 0, "float buffer compare with NaN entry");
+ }
+}
+