This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH, v3] PR 35954: rebuild of precompiled headers
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Fri, 18 Apr 2008 10:46:52 -0500
- Subject: Re: [PATCH, v3] PR 35954: rebuild of precompiled headers
- References: <20080418052130.GA31488@ins.uni-bonn.de>
> The 'touch' was added by
> <http://gcc.gnu.org/ml/libstdc++/2006-07/msg00080.html>. IMVHO it is
> superfluous: the header file is not newer just because a new
> precompiled header exists for it. The precompiled header should not
> generate rebuilds of depending files.
Agreed.
No, I think I was just sloppy when redoing this to remove installation
support for PCHes.
> was added because of the bug fixed in
> <http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01103.html> which hasn't
> been reviewed yet. But maybe there's another reason I'm not aware of?
I thought I reviewed this, but cannot find it in the archives. Will do
asap.
Can you send me links of any other unreviewed libstdc++ patches? Thanks.
> While we're at it, let's inline the 'mkdir -p' here, too, as it saves
> a fork during the first build, and doesn't increase the number of
> forks on subsequent builds. (And would fix potential parallel build
> errors for non-GNU make, not sure if that's relevant for libstdc++.)
>
> OK for trunk and 4.3? I've had this patch for a while, but I'll be
> bootstrapping it again just in case.
Yes, this is fine. Thanks for fixing this. Please put this on trunk and
gcc-4_3-branch.
-benjamin